piotrwolinski-intel commented on code in PR #20997:
URL: https://github.com/apache/incubator-mxnet/pull/20997#discussion_r879334267
##########
src/operator/nn/dnnl/dnnl_deconvolution-inl.h:
##########
@@ -130,24 +129,24 @@ class DNNLDeconvFwd {
std::shared_ptr<deconv_fwd_pd_t> fwd_pd;
};
-DNNLDeconvFwd::Tensors::Tensors(const bool no_bias,
- const std::vector<NDArray>& inputs,
- const std::vector<NDArray>& outputs)
- : data(inputs[deconv::kData]),
- weights(inputs[deconv::kWeight]),
- bias(no_bias ? nullptr : &inputs[deconv::kBias]),
- out(outputs[deconv::kOut]) {}
-
-DNNLDeconvFwd::Tensors::Tensors(const NDArray& data,
- const NDArray& weights,
- const NDArray* const bias,
- const NDArray& out)
- : data(data), weights(weights), bias(bias), out(out) {}
-
-DNNLDeconvFwd::DNNLDeconvFwd(const DeconvolutionParam& param, const Tensors&
tensors)
- : fwd_pd(CreatePrimitiveDesc(param, tensors)) {
- fwd = std::make_shared<deconv_fwd_t>(*fwd_pd);
-}
+// DNNLDeconvFwd::Tensors::Tensors(const bool no_bias,
+// const std::vector<NDArray>& inputs,
+// const std::vector<NDArray>& outputs)
+// : data(inputs[deconv::kData]),
+// weights(inputs[deconv::kWeight]),
+// bias(no_bias ? nullptr : &inputs[deconv::kBias]),
+// out(outputs[deconv::kOut]) {}
+
+// DNNLDeconvFwd::Tensors::Tensors(const NDArray& data,
+// const NDArray& weights,
+// const NDArray* const bias,
+// const NDArray& out)
+// : data(data), weights(weights), bias(bias), out(out) {}
+
+// DNNLDeconvFwd::DNNLDeconvFwd(const DeconvolutionParam& param, const
Tensors& tensors)
+// : fwd_pd(CreatePrimitiveDesc(param, tensors)) {
+// fwd = std::make_shared<deconv_fwd_t>(*fwd_pd);
+// }
Review Comment:
Yes, fixed it, thank You
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
