KellenSunderland commented on a change in pull request #8026: OSX CMake fixes
for tests binary
URL: https://github.com/apache/incubator-mxnet/pull/8026#discussion_r140732644
##########
File path: CMakeLists.txt
##########
@@ -152,7 +152,7 @@ include_directories("dlpack/include")
# add_subdirectory(dlpack)
#endif()
-if(NOT MSVC)
+if(NOT MSVC AND NOT APPLE)
Review comment:
clang doesn't support this flag. Static linking with default flags seems to
work properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
