KellenSunderland commented on a change in pull request #8026: OSX CMake fixes
for tests binary
URL: https://github.com/apache/incubator-mxnet/pull/8026#discussion_r140793348
##########
File path: tests/CMakeLists.txt
##########
@@ -39,7 +39,6 @@ if(GTEST_FOUND)
if(UNITTEST_STATIC_LINK)
target_link_libraries(${PROJECT_NAME}_unit_tests
${GTEST_LIBRARY}
- rt
Review comment:
I should make it clear that I'm not a cmake expert, but to me it looks like
it'll be included in mxnet_LINKER_LIBS from line
https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L225 when
required (i.e. in Unix, not apple). and mxnet_LINKER_LIBS is referenced both
here
https://github.com/apache/incubator-mxnet/blob/master/tests/CMakeLists.txt#L45
and here
https://github.com/apache/incubator-mxnet/blob/master/tests/CMakeLists.txt#L54
in the same scope as rt.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
