KellenSunderland commented on a change in pull request #8026: OSX CMake fixes 
for tests binary
URL: https://github.com/apache/incubator-mxnet/pull/8026#discussion_r140788618
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -218,14 +218,6 @@ else(USE_LAPACK)
   endif()
 endif()
 
-
 
 Review comment:
   This block 
https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L160 seems 
to be a copy and paste of this block 
https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L222 .  
Does having it twice serve some purpose, or are we just appending it to the 
same list twice?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to