ptrendx commented on a change in pull request #17265: Add bfloat16
floating-point format support based on AMP
URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r366978831
##########
File path: 3rdparty/mshadow/mshadow/base.h
##########
@@ -988,6 +1034,7 @@ struct minimum {
};
} // namespace red
+#ifndef __NVCC__
Review comment:
You can implement `atomicAdd` (which seems to be the problem you are
facing)with `atomicCAS` like this:
https://github.com/apache/incubator-mxnet/blob/master/src/common/cuda_utils.h#L702-L721
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
