ChaiBapchya commented on a change in pull request #17297: Fix NCCL Cmake
autodetect issue
URL: https://github.com/apache/incubator-mxnet/pull/17297#discussion_r366185864
##########
File path: cmake/Modules/FindNCCL.cmake
##########
@@ -33,6 +33,26 @@
set(NCCL_ROOT_DIR "" CACHE PATH "Folder contains NVIDIA NCCL")
+# if CUDAToolkit_FOUND is not found, try default location
+#if (NOT CUDAToolkit_FOUND)
+ if (UNIX)
+ set (search_paths "/usr/local/cuda")
+
+ find_path(NCCL_INCLUDE_DIRS
+ NAMES nccl.h
+ PATHS ${search_paths}
Review comment:
https://cmake.org/cmake/help/v3.4/command/find_path.html
Looks like either Hints or paths is permitted. Any specific reason to use
hints?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
