ChaiBapchya commented on a change in pull request #17297: Fix NCCL Cmake autodetect issue URL: https://github.com/apache/incubator-mxnet/pull/17297#discussion_r367575646
########## File path: cmake/Modules/FindNCCL.cmake ########## @@ -33,6 +33,23 @@ set(NCCL_ROOT_DIR "" CACHE PATH "Folder contains NVIDIA NCCL") +# first check in the /usr/local/cuda before other paths Review comment: Ya. Even I saw this NCCL_ROOT and found that NCCL_ROOT_DIR is deprecated hence no longer to be used in PyTorch repo https://github.com/pytorch/pytorch/blob/f94aab45fd7b1e7e32d8ea4324da6d3632a0d412/cmake/Modules/FindNCCL.cmake#L21 However, I couldn't find official cmake doc saying so. Nonetheless, I think I should add that too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
