ChaiBapchya commented on a change in pull request #17297: Fix NCCL Cmake 
autodetect issue
URL: https://github.com/apache/incubator-mxnet/pull/17297#discussion_r367201643
 
 

 ##########
 File path: cmake/Modules/FindNCCL.cmake
 ##########
 @@ -33,6 +33,23 @@
 
 set(NCCL_ROOT_DIR "" CACHE PATH "Folder contains NVIDIA NCCL")
 
+# first check in the /usr/local/cuda before other paths
 
 Review comment:
   I'm not sure why it breaks the assumption. Can you help me rephrase the 
comment? I can remove "first" if that's what confuses the users.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to