samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom 
operator GPU support
URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367702747
 
 

 ##########
 File path: src/c_api/c_api.cc
 ##########
 @@ -635,11 +698,20 @@ int MXLoadLib(const char *path) {
       CHECK(state_op_inst != nullptr)
       << "Error MXNet cannot load custom stateful operator'" << name_str << 
"'";
 
+      // pass the gpu stream associated with the context to custom library
+      void* gpu_stream = nullptr;
+      if (inputs[i].ctx().dev_mask() == Context::kGPU) {
 
 Review comment:
   what is `i` here for `inputs[i]`? shouldnt this be `inputs[0]`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to