ChaiBapchya commented on a change in pull request #17297: Fix NCCL Cmake autodetect issue URL: https://github.com/apache/incubator-mxnet/pull/17297#discussion_r367813676
########## File path: cmake/Modules/FindNCCL.cmake ########## @@ -33,6 +33,23 @@ set(NCCL_ROOT_DIR "" CACHE PATH "Folder contains NVIDIA NCCL") +# first check in the /usr/local/cuda before other paths Review comment: 1. NCCL_ROOT auto check - I guess it is done automatically. Though it's not mentioned explicitly anywhere. Hence asked here - https://stackoverflow.com/questions/59783425/does-cmake-find-path-find-library-search-for-packagename-root-by-default 2. > Also it seems none of the other Find modules check the X_LIB_DIR and X_LIB_DIR env variables. Not sure what you implying? You think that is superfluous too? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
