ChaiBapchya commented on a change in pull request #17297: Fix NCCL Cmake autodetect issue URL: https://github.com/apache/incubator-mxnet/pull/17297#discussion_r367701531
########## File path: cmake/Modules/FindNCCL.cmake ########## @@ -33,6 +33,23 @@ set(NCCL_ROOT_DIR "" CACHE PATH "Folder contains NVIDIA NCCL") +# first check in the /usr/local/cuda before other paths Review comment: Moved /usr/local/cuda check to be after other checks Also added NCCL_ROOT alongside NCCL_ROOT_DIR Also added deprecation warning for ROOT_DIR ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
