anandj91 commented on a change in pull request #15124: [MXNET-1294]
Priority-based parameter propagation for improved data parallel training
throughput
URL: https://github.com/apache/incubator-mxnet/pull/15124#discussion_r370454891
##########
File path: python/mxnet/kvstore/base.py
##########
@@ -452,4 +457,13 @@ def create(name='local'):
from .kvstore import KVStore
kv = KVStore(handle)
set_kvstore_handle(kv.handle)
- return kv
+
Review comment:
in that case, ps-lite already require DMLC_PS_VAN_TYPE env variable to be
set to use P3Van. Can we use the same env variable for MXNet as well? And we
don't need to introduce new --kvstore arguments (dist_p3). In the backend we
can check if DMLC_PS_VAN_TYPE is set to p3 and launch P3StoreDist instead of
KVStoreDist.
In order to make things easier, as you said, we can add another flag in
launch.py --p3. Otherwise users have to set both --p3 and --kvstore dist_p3.
Seems redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
