anandj91 commented on a change in pull request #15124: [MXNET-1294]
Priority-based parameter propagation for improved data parallel training
throughput
URL: https://github.com/apache/incubator-mxnet/pull/15124#discussion_r370945445
##########
File path: python/mxnet/kvstore/kvstore.py
##########
@@ -67,6 +68,7 @@ def __init__(self, handle):
self._updater = None
self._updater_func = None
self._str_updater_func = None
+ self._is_p3 = (os.getenv('DMLC_PS_VAN_TYPE', '') == 'p3')
Review comment:
sure. I just wanted to confirm if we are planning to only add --p3 to
launch.py now and not --horovod or --byteps because of the reasons I mentioned
in the previous comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
