anandj91 commented on a change in pull request #15124: [MXNET-1294] 
Priority-based parameter propagation for improved data parallel training 
throughput
URL: https://github.com/apache/incubator-mxnet/pull/15124#discussion_r370922591
 
 

 ##########
 File path: python/mxnet/kvstore/base.py
 ##########
 @@ -452,4 +457,13 @@ def create(name='local'):
         from .kvstore import KVStore
         kv = KVStore(handle)
         set_kvstore_handle(kv.handle)
-        return kv
+
 
 Review comment:
   looking at horovod and byteps, it doesn't seem like it is as easy as passing 
kv= argument into gluon.Trainer to use horovod and byteps. Using horovod and 
byteps require some code changes as well. So I'm not sure if it is possible to 
run launch.py with --horovod/--byteps flag and make them use corresponding 
communication mechanisms. It would work for kvstore and p3.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to