eric-haibin-lin commented on a change in pull request #15124: [MXNET-1294]
Priority-based parameter propagation for improved data parallel training
throughput
URL: https://github.com/apache/incubator-mxnet/pull/15124#discussion_r370967566
##########
File path: src/kvstore/kvstore_dist.h
##########
@@ -180,16 +183,22 @@ class KVStoreDist : public KVStoreLocal {
std::unordered_map<int, PSKV> ps_kv_;
std::unordered_map<int, ComprPSKV> compr_ps_kv_;
- /**
- * \brief serialize access to ps_kv_ or push_ps_kv_/pull_ps_kv_ while
encoding keys
- */
- std::mutex mu_;
+ private:
+ static std::atomic<int> customer_id_;
+
+ static int GetNewCustomerId() {
+ return customer_id_++;
+ }
void InitImpl(const std::vector<int>& keys,
const std::vector<NDArray>& values) override {
CheckUnique(keys);
for (size_t i = 0; i < keys.size(); ++i) {
comm_->Init(keys[i], values[i].storage_type(), values[i].shape(),
values[i].dtype());
+ /* Fix the key encoding */
Review comment:
Does this assume storage_type = default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
