eric-haibin-lin commented on a change in pull request #15124: [MXNET-1294] Priority-based parameter propagation for improved data parallel training throughput URL: https://github.com/apache/incubator-mxnet/pull/15124#discussion_r373284934
########## File path: python/mxnet/kvstore/kvstore.py ########## @@ -67,6 +68,7 @@ def __init__(self, handle): self._updater = None self._updater_func = None self._str_updater_func = None + self._is_p3 = (os.getenv('DMLC_PS_VAN_TYPE', '') == 'p3') Review comment: @apeforest because the source code lives inside mxnet, it supports both device and local mode, and can share the same python KVStore class ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services