eric-haibin-lin commented on a change in pull request #15124: [MXNET-1294]
Priority-based parameter propagation for improved data parallel training
throughput
URL: https://github.com/apache/incubator-mxnet/pull/15124#discussion_r373284934
##########
File path: python/mxnet/kvstore/kvstore.py
##########
@@ -67,6 +68,7 @@ def __init__(self, handle):
self._updater = None
self._updater_func = None
self._str_updater_func = None
+ self._is_p3 = (os.getenv('DMLC_PS_VAN_TYPE', '') == 'p3')
Review comment:
@anandj91 and I had a recent discussion. Having separate python kvstore
class for p3 leads to lots of duplicated code because it also supports both
device and local mode. Its source code lives inside mxnet, and sharing the same
python KVStore class is reasonable in terms of complexity and maintenance
efforts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
