anandj91 commented on a change in pull request #15124: [MXNET-1294]
Priority-based parameter propagation for improved data parallel training
throughput
URL: https://github.com/apache/incubator-mxnet/pull/15124#discussion_r371057975
##########
File path: python/mxnet/kvstore/kvstore.py
##########
@@ -349,6 +363,7 @@ def pushpull(self, key, value, out=None, priority=0):
out: NDArray or list of NDArray or list of list of NDArray
Values corresponding to the keys.
+ `out` should have length as `value`.
Review comment:
there is grouping of keys and corresponding ndarrays happening at the
backend based on their positions in the list before performing kv operations.
Since we are using same key list for both value and out, their layouts should
be identical. length check is just for a sanity.
this is the reason why I had both vkeys and okeys separate in the previous
implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
