connorgoggins opened a new pull request #17500: [OpPerf] Implement remaining nn_conv ops in opperf URL: https://github.com/apache/incubator-mxnet/pull/17500 ## Description ## This PR serves to implement the remaining operators from the nn_conv category in opperf. To achieve this, I added a call to `run_performance_test` for the `ROIPooling` op within the `run_pooling_operators_benchmarks` function and added the `rois` argument to the NDArray list in `default_params.py`. Since `ROIPooling` was the only remaining op in the convolutional ops category, these were the only changes required. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage - [x] Code is well-documented - [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - M benchmark/opperf/nd_operations/nn_conv_operators.py - M benchmark/opperf/rules/default_params.py ## Comments ## Tested on p2.16xl w/ubuntu 16.04 and Mac OS with: 1. Checkout branch and call function `run_pooling_operators_benchmarks` - runs all pooling ops (`Pooling` and `ROIPooling`) on relevant data 2. Checkout branch and run `opperf.py` (full run of all ops) ## Performance Results ## [Group of operator test - all Pooling ops (CPU)](https://gist.github.com/connorgoggins/0be00933c0087065bf5702ec2b9f2523) [Full OpPerf test (CPU)](https://gist.github.com/connorgoggins/cfbcd7661779bd322783c1f288937977) [Group of operator test - all Pooling ops (GPU)](https://gist.github.com/connorgoggins/125606f8e5243e1a670fa41c40ad420c) [Full OpPerf test (GPU)](https://gist.github.com/connorgoggins/c65fbe4e7c537653bdae8dec9a1e6d84) @apeforest @access2rohit @ChaiBapchya
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
