ChaiBapchya commented on issue #17500: [OpPerf] Implement remaining nn_conv ops 
in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17500#issuecomment-581231771
 
 
   > Either explicitly document this requirement in the README or remove this 
requirement so the users can run benchmark directly after mxnet is pip 
installed.
   
   
https://github.com/apache/incubator-mxnet/tree/master/benchmark/opperf#prerequisites
   
   Doesn't this say "add path to your cloned MXNet repository to the PYTHONPATH"
   
   I'll add a comment that "explicitly" asks to "clone" the repo.
   Also I'll try to see if this requirement can be removed and user can run 
benchmark directly with pip. But that would involve broader (time-consuming 
possibly) discussion so will do it later.
   
   > It would be better to add print(add_res) explicitly to the code snippet in 
the README.md.
   
   I will add that print() statement explicitly to README too.
   
   Thanks for pointing out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to