ChaiBapchya commented on issue #17500: [OpPerf] Implement remaining nn_conv ops 
in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17500#issuecomment-582129467
 
 
   > Thank you @ChaiBapchya
   > 
   > > So if you print add_res you will see the details.
   > 
   > It would be better to add `print(add_res)` explicitly to the code snippet 
in the README.md.
   > 
   > > Yes, as it currently stands opperf utility can only be used after 
cloning the repo and setting the PYTHONPATH to the repo.
   > 
   > Either explicitly document this requirement in the README or remove this 
requirement so the users can run benchmark directly after mxnet is pip 
installed.
   
   @TaoLv As requested, add the 2 changes to my existing PR - 
   specifically this commit - 
https://github.com/apache/incubator-mxnet/pull/17487/commits/4228baac8dff5c987c64c49d66f954754291eb6c
   Does this help?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to