fomkin opened a new pull request #17503: Add Scala 2.12 and 2.13 cross-compilation (#16438) URL: https://github.com/apache/incubator-mxnet/pull/17503 ## Description ## Currently MXNet support only ancient Scala 2.11. I found mentions of try to add support of Scala 2.12 but looks like the try was failed despite the fact that PR was merged. This PR is another try. ## Comments ## - API compatibility was completely saved - Add `scala-2.11`, `scala-2.12` and `scala-2.13` Maven profiles. Now one of the profiles should be active. This condition is checked by `maven-enforcer-plugin` - Add Support of Scala 2.13 collections to C++ JNI code - Module "Examples" builds only for 2.11. Dependencies were obsolete and there is no way to port examples without rewriting of logic (this is out of scope of the PR) - Module "Spark ML" builds only for 2.11. It depends on Spark 1.6.3 which supports only 2.11 - *Possible performance degradation in 2.13 version*. Scala 2.13 has new collections library. Default `Seq` is immutable now, so I need to ivoke `toSeq` for each `ArrayBuffer` to copy it to immutable sequence ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [ ] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### To solve ### 1. [ ] I did something and `BertQA` starts to compile (looks like it was ignored before). It breaks compilation of examples. I don't know what to do. I'm nood in neural networks and not know how no modify the code to make it compile. 2. [ ] Makefile and CI integration.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
