zachgk commented on a change in pull request #17503: Add Scala 2.12 and 2.13
cross-compilation (#16438)
URL: https://github.com/apache/incubator-mxnet/pull/17503#discussion_r378544678
##########
File path: scala-package/assembly/pom.xml
##########
@@ -26,7 +26,7 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <artifactId>mxnet-full_2.11</artifactId>
+ <artifactId>mxnet-full</artifactId>
Review comment:
Is there a reason you are removing the _{scala.binary.version} from the
internal artifactId? This could end up breaking other users
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
