zachgk commented on a change in pull request #17503: Add Scala 2.12 and 2.13
cross-compilation (#16438)
URL: https://github.com/apache/incubator-mxnet/pull/17503#discussion_r378551886
##########
File path: scala-package/pom.xml
##########
@@ -423,23 +590,11 @@
<version>1.7.7</version>
<scope>provided</scope>
</dependency>
- <dependency>
- <groupId>org.scalatest</groupId>
- <artifactId>scalatest_2.11</artifactId>
Review comment:
Can you try to keep the dependencies in the dependency section so it is
easier to keep track of them. For scalatest, you could just use
`<artifactId>scalatest_${scala.binary.version}</artifactId>`. If you need to
vary the version, you could use a property.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
