fomkin commented on a change in pull request #17503: Add Scala 2.12 and 2.13
cross-compilation (#16438)
URL: https://github.com/apache/incubator-mxnet/pull/17503#discussion_r378685736
##########
File path: scala-package/assembly/pom.xml
##########
@@ -26,7 +26,7 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <artifactId>mxnet-full_2.11</artifactId>
+ <artifactId>mxnet-full</artifactId>
Review comment:
This is an artifactId in the Maven _reactor_ scope. Concrete Scala version
suffix adds on deploy/install phase (see `deploy/pom.xml`). It means that
artifact published to the Central will have proper Scala version suffix. So it
shouldn't break other users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
