apeforest commented on a change in pull request #17462: Updated
PartialSortSmallK for LT support
URL: https://github.com/apache/incubator-mxnet/pull/17462#discussion_r381492237
##########
File path: src/operator/tensor/ordering_op-inl.h
##########
@@ -362,7 +362,7 @@ MSHADOW_FORCE_INLINE void TopKSort(const Tensor<gpu, 1,
DType>& dat,
}
} else {
const int nthreads(mshadow::cuda::kBaseThreadNum);
- PartialSortSmallK<<<M, nthreads, nthreads*K*(sizeof(int)+sizeof(DType)),
+ PartialSortSmallK<<<M, nthreads, nthreads*K*(sizeof(IType)+sizeof(DType)),
Review comment:
@ptrendx If we look at the [memory profiling result
](https://github.com/apache/incubator-mxnet/pull/17462#issuecomment-579961169)
posted by @JonTanS, there IS a ~10% max memory increase and ~5% average memory
increase caused by this solely change.
@JonTanS could you please re-run the profiler again to make sure the memory
result is accurate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
