apeforest commented on a change in pull request #17462: Updated PartialSortSmallK for LT support URL: https://github.com/apache/incubator-mxnet/pull/17462#discussion_r381547859
########## File path: src/operator/tensor/ordering_op-inl.h ########## @@ -362,7 +362,7 @@ MSHADOW_FORCE_INLINE void TopKSort(const Tensor<gpu, 1, DType>& dat, } } else { const int nthreads(mshadow::cuda::kBaseThreadNum); - PartialSortSmallK<<<M, nthreads, nthreads*K*(sizeof(int)+sizeof(DType)), + PartialSortSmallK<<<M, nthreads, nthreads*K*(sizeof(IType)+sizeof(DType)), Review comment: @JonTanS could you also move the memory comparison results to the PR description so it's more noticeable to reviewers? Thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services