JonTanS commented on issue #17462: Updated PartialSortSmallK for LT support URL: https://github.com/apache/incubator-mxnet/pull/17462#issuecomment-589254247 > > but they still seem pretty close. > > Not sure what you mean by "pretty close". It still looks like 10% memory increase (both average and max) to me. Could you please clarify if I misread the table? @apeforest Yes, so I think what we are trying to figure out now is whether changing int -> index_t caused any regression. We aren't comparing between LT on and off because there may have been other changes that caused the memory regression. Looking at the max between the build with int and index_t without LT enabled we have 1245 vs 1256. Looking at the max between LT_int and LT_index_t we have 1378 and 1380. These numbers are pretty similar meaning that the index_t change does not cause a regression, instead it may be due to other features of LT causing this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
