samskalicky commented on a change in pull request #17623: Dynamic subgraph
compile support
URL: https://github.com/apache/incubator-mxnet/pull/17623#discussion_r384248544
##########
File path: src/operator/subgraph/build_subgraph.cc
##########
@@ -561,10 +561,12 @@ void CutGraphInputs(const std::vector<nnvm::NodeEntry*>
&input_entries,
nnvm::ObjectPtr n = nnvm::CreateVariableNode(
var_name + std::to_string(name_count_map[var_name]));
// set attribute for subgraph input to indicate if it is from an arg/param
to model
- if (e->node->is_variable())
+ if (e->node->is_variable()) {
n->attrs.dict["isArg"] = "True";
- else
+ n->attrs.dict["argName"] = var_name;
Review comment:
auxName is not necessary.` argName` will be set for all "variables" which
includes both args and aux.
for an arg param, isArg = True && argName = 'bob'
for an aux param, isArg = True && isAux = true && argName = 'bob'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
