samskalicky commented on a change in pull request #17623: Dynamic subgraph
compile support
URL: https://github.com/apache/incubator-mxnet/pull/17623#discussion_r384302249
##########
File path: example/extensions/lib_subgraph/README.md
##########
@@ -120,11 +122,8 @@ There are several essential building blocks for making a
custom partitioner:
* This macro registers the custom partitioner and its properties to MXNet
by its name. Notice that a partitioner can have multiple partitioning
strategies. This enables multiple *passes* to be run in a single partitioning
call from the user. The first argument to `addStrategy` is a user-specified
name. The second argument is the `supportedOps` function. The third argument is
the name of the subgraph operator to create for each subgraph created during
partitioning (see below for more info about subgraph operators). The
`setReviewSubgraph` API registers a callback function that is called for each
subgraph created during partitioning (more on this below). Notice that the
first argument to this function is the strategy to associate with and the
second argument is the `reviewSubgraph` function.
REGISTER_PARTITIONER(my_part_name)
- .addStrategy("strategy1",
- supportedOps,
- "_custom_subgraph_op")
- .setReviewSubgraph("strategy1",
- reviewSubgraph);
+ .addStrategy("strategy1", supportedOps, "_custom_subgraph_op")
+ .setReviewSubgraph("strategy1", reviewSubgraph);
Review comment:
thanks for the reminder, done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
