samskalicky commented on a change in pull request #17623: Dynamic subgraph 
compile support
URL: https://github.com/apache/incubator-mxnet/pull/17623#discussion_r384247937
 
 

 ##########
 File path: python/mxnet/gluon/block.py
 ##########
 @@ -1026,6 +1030,53 @@ def _call_cached_op(self, *args):
             out = [out]
         return _regroup(out, self._out_format)
 
+    def optimize_for(self, x, *args, backend=None, backend_opts=None, 
**kwargs):
 
 Review comment:
   nope. in Gluon `args` here means inputs to the model. not the same as 
args/aux in symbol/module flow. These are the same function arguments as used 
in the `forward` API:
   
https://github.com/apache/incubator-mxnet/blob/13f5ad967992d92016667e8c9387ec128d43f01f/python/mxnet/gluon/block.py#L1155-L1158

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to