access2rohit commented on a change in pull request #17632: [Large Tensor] Fixed
RNN op
URL: https://github.com/apache/incubator-mxnet/pull/17632#discussion_r385397242
##########
File path: src/operator/rnn-inl.h
##########
@@ -123,7 +123,7 @@ struct RNNParam : public dmlc::Parameter<RNNParam> {
};
inline int GetRnnParamSize(int num_layer,
- int input_size,
+ index_t input_size,
Review comment:
size_t ? make sure API signature doesn't chage. If thats the case then keep
it index_t
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
