connorgoggins commented on a change in pull request #17632: [Large Tensor] Fixed RNN op URL: https://github.com/apache/incubator-mxnet/pull/17632#discussion_r385985781
########## File path: src/operator/rnn_impl.h ########## @@ -146,15 +146,15 @@ void LstmForwardTraining(DType* ws, Tensor<cpu, 3, DType> hx(hx_ptr, Shape3(total_layers, N, H)); Tensor<cpu, 3, DType> cx(cx_ptr, Shape3(total_layers, N, H)); const int b_size = 2 * H * 4; Review comment: As discussed offline: `H` represents the LSTM state size, and we are not supporting LSTM states w/dimension >= 2**32, so `b_size` should remain an `int`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
