connorgoggins commented on a change in pull request #17632: [Large Tensor]
Fixed RNN op
URL: https://github.com/apache/incubator-mxnet/pull/17632#discussion_r385971999
##########
File path: src/operator/rnn_impl.h
##########
@@ -127,9 +127,9 @@ void LstmForwardTraining(DType* ws,
bool state_outputs,
const int L,
const int D,
Review comment:
L is `num_layers`, and D is `direction`. I believe we agreed that we would
not support > 2**32 layers, so L should be fine as an `int`. D can have two
possible values, 0 or 1, to indicate whether to run the op with bidirectional
recurrent layers. Consequently, D*L can never be >5B.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
