zixuanweeei commented on a change in pull request #17632: [Large Tensor] Fixed
RNN op
URL: https://github.com/apache/incubator-mxnet/pull/17632#discussion_r386861281
##########
File path: src/operator/rnn-inl.h
##########
@@ -123,7 +123,7 @@ struct RNNParam : public dmlc::Parameter<RNNParam> {
};
inline int GetRnnParamSize(int num_layer,
Review comment:
Should return `index_t` type? Maybe overflow with a large input size. And
the UT only covers cases for large sequence length (first dimension of RNN
input data). Would you mind taking some tests for a case with a large input to
see whether this function still works?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
