samskalicky commented on a change in pull request #17762: Custom Operator Random Number Generator Support URL: https://github.com/apache/incubator-mxnet/pull/17762#discussion_r399430932
########## File path: include/mxnet/lib_api.h ########## @@ -426,21 +432,30 @@ typedef void (*sparse_malloc_t)(void*, int, int, int, void**, int64_t**, int64_t #if defined(__NVCC__) typedef cudaStream_t mx_stream_t; + typedef curandStatePhilox4_32_10_t* mx_gpu_rand_pt; Review comment: since this is a typedef, lets follow the naming style and call it mx_gpu_rand_t should we typedef std::mt19937 to mx_cpu_rand_t too? or is that going too far? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
