samskalicky commented on a change in pull request #17762: Custom Operator 
Random Number Generator Support
URL: https://github.com/apache/incubator-mxnet/pull/17762#discussion_r399432140
 
 

 ##########
 File path: include/mxnet/lib_api.h
 ##########
 @@ -1345,7 +1378,7 @@ extern "C" {
     }
 
     OpResource res(cpu_malloc, cpu_alloc, gpu_malloc, gpu_alloc,
-                   cuda_stream, sparse_malloc, sparse_alloc);
+                   cuda_stream, sparse_malloc, sparse_alloc, cpu_states, 
gpu_states);
 
 Review comment:
   can we rename it here too?
   
   Just dont want "states" to be confused with stateful ops

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to