connorgoggins commented on a change in pull request #17948: [Website 2.0]
General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402024023
##########
File path: docs/static_site/Makefile
##########
@@ -20,7 +20,7 @@ all: html
html:
mkdir -p build
cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll
build --config _config_prod.yml -d ../build/html && cd ..
-
+ wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip &&
unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm
versions.zip
Review comment:
Thanks for your question, @marcoabreu. The content for the static artifacts
is managed in [this
repository](https://github.com/connorgoggins/mxnet-website-artifacts).
Originally this line was a call to directly clone the repository, but based on
feedback it was decided that it would be better to not rely on external
repositories and pull the artifacts from an S3 bucket instead.
Here, S3 isn't being used as the way multiple Jenkins jobs exchange data per
se. There are many older static artifacts in the ZIP that have gone through
multiple rounds of changes which are tracked in the aforementioned repository,
rather than simply being built by another Jenkins pipeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services