szha commented on a change in pull request #17948: [Website 2.0] General
Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402568771
##########
File path: docs/static_site/Makefile
##########
@@ -20,7 +20,7 @@ all: html
html:
mkdir -p build
cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll
build --config _config_prod.yml -d ../build/html && cd ..
-
+ wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip &&
unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm
versions.zip
Review comment:
Indeed, this is a static artifact that can't be directly updated by the
community. For a complete solution, we definitely need them to be generated.
On the other hand, the lack of website versioning is such a pressing issue
that it has come up multiple times, even in past release votes, and is still
actively causing confusion for many current and prospective users. We must be
losing user base because of this.
If the contributors could come up with a plan for a solution that's based on
automatically generated content, and execute the plan before any of our next
releases, I think we should accept this solution for now to address the
immediate need for avoiding confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
