marcoabreu commented on a change in pull request #17948: [Website 2.0] General
Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402484692
##########
File path: docs/static_site/Makefile
##########
@@ -20,7 +20,7 @@ all: html
html:
mkdir -p build
cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll
build --config _config_prod.yml -d ../build/html && cd ..
-
+ wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip &&
unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm
versions.zip
Review comment:
But how would you invalidate that cache?
I think it's important to have continuity to allow a contributor to
understand and also reproduce how our website gets created. As it stands right
now, people would not be able to facilitate this.
What happened to the idea with the Jenkins jobs creating artifacts and
another job consuming these artifacts to then assemble the website?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
