sandeep-krishnamurthy commented on a change in pull request #17948: [Website
2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402714515
##########
File path: docs/static_site/Makefile
##########
@@ -20,7 +20,7 @@ all: html
html:
mkdir -p build
cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll
build --config _config_prod.yml -d ../build/html && cd ..
-
+ wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip &&
unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm
versions.zip
Review comment:
@marcoabreu Thanks for your feedback and I fully agree that if generation of
web content happens through Jenkins in an automated way, all community members
can participate in the updates. In that direction, @connorgoggins already has
PRs to make 1.x and 2.x branches auto builds. The fix here is very critical for
MXNet community. Without this change, users are unable to use MXNet website.
One concern would be if there is a patch release on 1.6.x then someone needs to
regenerate static artifacts. Given that @connorgoggins already documented steps
for the same and his other contributions I see this as a non-blocking issue
that will not leave MXNet community in limbo.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
