marcoabreu commented on a change in pull request #18056: Fix ci/docker_cache.py URL: https://github.com/apache/incubator-mxnet/pull/18056#discussion_r408411038
########## File path: ci/build.py ########## @@ -71,7 +71,7 @@ def get_docker_binary(use_nvidia_docker: bool) -> str: def build_docker(platform: str, docker_binary: str, registry: str, num_retries: int, no_cache: bool, - cache_intermediate: bool) -> str: + cache_intermediate: bool = False) -> str: Review comment: This has to be true. Otherwise, a single change will result in a full rebuild, drastically increasing build times. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
