marcoabreu commented on a change in pull request #18056: Fix ci/docker_cache.py
URL: https://github.com/apache/incubator-mxnet/pull/18056#discussion_r408509392
 
 

 ##########
 File path: ci/build.py
 ##########
 @@ -71,7 +71,7 @@ def get_docker_binary(use_nvidia_docker: bool) -> str:
 
 
 def build_docker(platform: str, docker_binary: str, registry: str, 
num_retries: int, no_cache: bool,
-                 cache_intermediate: bool) -> str:
+                 cache_intermediate: bool = False) -> str:
 
 Review comment:
   Yeah it should be possible. It will just cause issues if the test fails 
since that might mean that stuff gets left dangling, but due to the mentioned 
lifecycle, that shouldn't have a big impact.
   
   Feel free to enable it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to