marcoabreu commented on a change in pull request #18056: Fix ci/docker_cache.py URL: https://github.com/apache/incubator-mxnet/pull/18056#discussion_r408509009
########## File path: ci/build.py ########## @@ -71,7 +71,7 @@ def get_docker_binary(use_nvidia_docker: bool) -> str: def build_docker(platform: str, docker_binary: str, registry: str, num_retries: int, no_cache: bool, - cache_intermediate: bool) -> str: + cache_intermediate: bool = False) -> str: Review comment: CI does not docker purge automatically. But since the lifecycle of unix slaves is very very short, it's not an issue. Also, in 99% of the cases, no new layers are built and only the cache is used, so the likelyhood of a single slave regenerating a lot of new mismatching layers is quite low. On a dev machine though, that's a different case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
