ys2843 commented on a change in pull request #18512:
URL: https://github.com/apache/incubator-mxnet/pull/18512#discussion_r437116365
##########
File path: docs/static_site/src/.htaccess
##########
@@ -3,6 +3,25 @@ DirectorySlash off
RewriteEngine on
RewriteOptions AllowNoSlash
+<IfModule mod_expires.c>
+ ExpiresActive on
+
+ # Images
+ ExpiresByType image/png "access plus 7 days"
+ ExpiresByType image/jpg "access plus 7 days"
+ ExpiresByType image/jpeg "access plus 7 days"
+ ExpiresByType image/svg+xml "access plus 7 days"
+
+ # CSS, Javascript, HTML
Review comment:
Good question, it basically just preserves the current HTML "cache
control" (no cache and verify diff by ETag) and extends CSS/JS cache control to
1 day. By not caching HTML, new features/contents can be published without
delay.
##########
File path: docs/static_site/src/assets/js/jquery-3.3.1.min.js
##########
@@ -0,0 +1,20 @@
+/*!
Review comment:
Good idea, do we have existing S3 for this purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
