ys2843 commented on a change in pull request #18512:
URL: https://github.com/apache/incubator-mxnet/pull/18512#discussion_r437754444
##########
File path: docs/static_site/src/assets/js/jquery-3.3.1.min.js
##########
@@ -0,0 +1,20 @@
+/*!
Review comment:
Thought this through again and found it could import potential problems
by storing it on S3. It will require pulling the script when not only build on
Jenkins, but also develop locally. If someone has trouble or high latency
accessing our S3, the building process could break.
Found a more general approach would be using node package manager. It helps
a lot when managing many dependencies, however we only have this one dependency
now, it would import more complexity than benefit.
I would say for now still keep it within the project, ([other
projects](https://github.com/apache/incubator-echarts-website/blob/asf-site/en/vendors/jquery/jquery.js)
also do), and keep NPM as a candidate, switch to it when we need to handle
more dependencies :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
