connorgoggins commented on a change in pull request #18512:
URL: https://github.com/apache/incubator-mxnet/pull/18512#discussion_r437033884
##########
File path: docs/static_site/src/_sass/generalVersionDropdown.scss
##########
@@ -0,0 +1,41 @@
+.dropdown-option-active {
Review comment:
Nice! Definitely cleaner to have this in its own file, excellent work :)
##########
File path: docs/static_site/src/assets/js/jquery-3.3.1.min.js
##########
@@ -0,0 +1,20 @@
+/*!
Review comment:
Is keeping this in GitHub the best course of action? Couldn't we store
this in an S3 bucket and pull it during build time via Jenkins?
##########
File path: docs/static_site/src/.htaccess
##########
@@ -3,6 +3,25 @@ DirectorySlash off
RewriteEngine on
RewriteOptions AllowNoSlash
+<IfModule mod_expires.c>
+ ExpiresActive on
+
+ # Images
+ ExpiresByType image/png "access plus 7 days"
+ ExpiresByType image/jpg "access plus 7 days"
+ ExpiresByType image/jpeg "access plus 7 days"
+ ExpiresByType image/svg+xml "access plus 7 days"
+
+ # CSS, Javascript, HTML
Review comment:
Just curious, why are we caching JS & CSS but not HTML?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
