ys2843 commented on a change in pull request #18512:
URL: https://github.com/apache/incubator-mxnet/pull/18512#discussion_r437873468
##########
File path: docs/static_site/src/assets/js/jquery-3.3.1.min.js
##########
@@ -0,0 +1,20 @@
+/*!
Review comment:
Agreed on the point of building on Jenkins. However, the problem (local
latency) I was concerning is that when develop the main site locally (run
`jekyll serve` and website host on 127.0.0.1), it is also the time that the
script need to be pulled from S3, and geographical location might affect the
accessibility to this script.
If we really want to get rid of JQuery on Git, a way I can think of is that
on one hand using S3/CDN for building on Jenkins, and for local dev, updating
the doc/makefile to add the wget JQuery command before `jekyll serve`. wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
