connorgoggins commented on a change in pull request #18512:
URL: https://github.com/apache/incubator-mxnet/pull/18512#discussion_r437843141
##########
File path: docs/static_site/src/assets/js/jquery-3.3.1.min.js
##########
@@ -0,0 +1,20 @@
+/*!
Review comment:
Agreed that NPM would introduce more complexity than is necessary for
including this single file, but downloading the file at build time would be as
simple as adding a `wget` call to the Makefile for building the static site -
see
[here](https://github.com/apache/incubator-mxnet/pull/18340/files#diff-8938828e17dfd3968ac4048a65029ecfR23)
for an example. You wouldn't even need to add the file to S3 - you could pull
it directly from the CDN [here](http://code.jquery.com/jquery-3.3.1.min.js)
during build time and download it to the `assets/js` directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
