reminisce commented on a change in pull request #9306: Sequence Operator
Improvements
URL: https://github.com/apache/incubator-mxnet/pull/9306#discussion_r160508623
##########
File path: src/operator/sequence_last-inl.h
##########
@@ -45,16 +45,46 @@ namespace op {
namespace seq_last {
enum SequenceLastOpInputs { kData, kSequenceLength };
enum SequenceLastOpOutputs { kOut };
+enum SequenceLastOpResource { kTempSpace };
}
struct SequenceLastParam : public dmlc::Parameter<SequenceLastParam> {
bool use_sequence_length;
+ uint32_t axis;
Review comment:
Is it possible to support negative axis in the future? If so, it's better to
define it as a signed integer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
